Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle translate3d transforms on resizable elements #122

Merged
merged 1 commit into from
May 22, 2020

Conversation

henriqueantunes
Copy link
Contributor

Hi there! First of all thanks for the directive! Its been very useful.

I Checked the pull requests and saw that there was a pull request rejected for exacly the problem i was facing using the resizable with angular cdk drag-drop. So i made the fix in a slightly different way so it doesn't break the test with the regular "translate" and made a test case for the "translate3d".

Hope it helps!

Copy link
Owner

@mattlewis92 mattlewis92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thank you! 😄

@mattlewis92 mattlewis92 changed the title fix: allow translate3d transforms on getElementRect() fix: handle translate3d transforms on resizable elements May 22, 2020
@mattlewis92 mattlewis92 merged commit 534bdf6 into mattlewis92:master May 22, 2020
@mattlewis92
Copy link
Owner

Released as 3.3.1, thanks for your contribution! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants